Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1789666 azure/core-http deprecated #951

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sfc-gh-dszmolka
Copy link
Collaborator

@sfc-gh-dszmolka sfc-gh-dszmolka commented Nov 7, 2024

Description

Upon npm installing snowflake-sdk, following deprecation warning is emitted:

npm WARN deprecated @azure/core-http@3.0.4: This package is no longer supported. Please migrate to use @azure/core-rest-pipeline

This deprecated dependency on azure/core-http comes transiently from @azure/storage-blob@12.18.0

"@azure/core-http": "^3.0.0",

on which we depend with "@azure/storage-blob": "12.18.x"

next version @azure/storage-blob@12.23.0 doesn't have this dependency anymore, has

"@azure/core-http-compat": "^2.0.0",
..
"@azure/core-rest-pipeline": "^1.10.1",

instead. Recommendation per deprecation message is to migrate to @azure/core-rest-pipeline, which they did per changelog too.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

azure/core-http transient dependency coming from azure/storage-blob@12.18.x . 

Starting from azure/storage-blob@12.23.x and above, they migrated their dependency on azure/core-http to azure/core-rest-pipeline
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.90%. Comparing base (0aaa740) to head (63feffa).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #951      +/-   ##
==========================================
- Coverage   88.92%   88.90%   -0.02%     
==========================================
  Files          72       72              
  Lines        6950     6950              
==========================================
- Hits         6180     6179       -1     
- Misses        770      771       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dszmolka
Copy link
Collaborator Author

tests on Azure node 14.x are failing, so likely we'll need to wait until we deprecate node:14

@sfc-gh-dszmolka
Copy link
Collaborator Author

now with release v2.0.0, support for node:14 is dropped. GH tests seem to be successful, but Jenkins looks sick a bit. Waiting for it to recover to have those tests in the green too.

@sfc-gh-dszmolka sfc-gh-dszmolka marked this pull request as ready for review December 17, 2024 11:47
@sfc-gh-dszmolka sfc-gh-dszmolka requested a review from a team as a code owner December 17, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants