-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1789666 azure/core-http deprecated #951
base: master
Are you sure you want to change the base?
Conversation
azure/core-http transient dependency coming from azure/storage-blob@12.18.x . Starting from azure/storage-blob@12.23.x and above, they migrated their dependency on azure/core-http to azure/core-rest-pipeline
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #951 +/- ##
==========================================
- Coverage 88.92% 88.90% -0.02%
==========================================
Files 72 72
Lines 6950 6950
==========================================
- Hits 6180 6179 -1
- Misses 770 771 +1 ☔ View full report in Codecov by Sentry. |
tests on Azure node 14.x are failing, so likely we'll need to wait until we deprecate node:14 |
now with release v2.0.0, support for node:14 is dropped. GH tests seem to be successful, but Jenkins looks sick a bit. Waiting for it to recover to have those tests in the green too. |
…mits), as it was released while we were waiting for node:14 deprecation on Snowflake end
Description
Upon
npm install
ingsnowflake-sdk
, following deprecation warning is emitted:This deprecated dependency on
azure/core-http
comes transiently from @azure/storage-blob@12.18.0on which we depend with
"@azure/storage-blob": "12.18.x"
next version @azure/storage-blob@12.23.0 doesn't have this dependency anymore, has
instead. Recommendation per deprecation message is to migrate to
@azure/core-rest-pipeline
, which they did per changelog too.Checklist
npm run lint:check -- CHANGED_FILES
and fix problems in changed code)npm run test:unit
andnpm run test:integration
)