-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1781419: when proxy is set in Connection, driver does send traffic through the proxy to S3, but not to Azure blob / GCS bucket (only Snowflake). Works with proxy envvar (Azure) #964
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #964 +/- ##
==========================================
- Coverage 88.94% 88.83% -0.11%
==========================================
Files 70 71 +1
Lines 6830 6889 +59
==========================================
+ Hits 6075 6120 +45
- Misses 755 769 +14 ☔ View full report in Codecov by Sentry. |
sfc-gh-ext-simba-jy
requested review from
sfc-gh-pmotacki,
sfc-gh-dszmolka and
sfc-gh-dprzybysz
November 19, 2024 01:22
sfc-gh-pmotacki
approved these changes
Dec 6, 2024
sfc-gh-pmotacki
force-pushed
the
SNOW-1781419
branch
from
December 6, 2024 12:26
1951d3f
to
da27b2f
Compare
sfc-gh-dprzybysz
approved these changes
Dec 6, 2024
sfc-gh-pmotacki
force-pushed
the
SNOW-1781419
branch
from
December 6, 2024 13:07
91ab906
to
d65674b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Checklist
npm run lint:check -- CHANGED_FILES
and fix problems in changed code)npm run test:unit
andnpm run test:integration
)