Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1781419: when proxy is set in Connection, driver does send traffic through the proxy to S3, but not to Azure blob / GCS bucket (only Snowflake). Works with proxy envvar (Azure) #964

Merged
merged 18 commits into from
Dec 6, 2024

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy commented Nov 18, 2024

Description

Please explain the changes you made here.

  • Added the proxy setting in Azure_util
  • Separate the proxy util functions from util.js. Created proxy_util.js and proxy_util_test.js
  • Added connectionConfig in AzureUtil tests.
  • Refactored the code to validate and obtain proxy info in NoteHttpClient, Azure_util, and S3_util.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a team as a code owner November 18, 2024 21:47
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 89.58333% with 15 lines in your changes missing coverage. Please review.

Project coverage is 88.83%. Comparing base (a714851) to head (d65674b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/proxy_util.js 90.83% 11 Missing ⚠️
lib/file_transfer_agent/azure_util.js 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #964      +/-   ##
==========================================
- Coverage   88.94%   88.83%   -0.11%     
==========================================
  Files          70       71       +1     
  Lines        6830     6889      +59     
==========================================
+ Hits         6075     6120      +45     
- Misses        755      769      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/proxy_util.js Outdated Show resolved Hide resolved
lib/proxy_util.js Show resolved Hide resolved
lib/proxy_util.js Outdated Show resolved Hide resolved
lib/proxy_util.js Show resolved Hide resolved
lib/proxy_util.js Outdated Show resolved Hide resolved
lib/file_transfer_agent/azure_util.js Show resolved Hide resolved
test/unit/util_test.js Outdated Show resolved Hide resolved
lib/file_transfer_agent/azure_util.js Show resolved Hide resolved
lib/proxy_util.js Outdated Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit bf3b4c2 into master Dec 6, 2024
57 of 58 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-1781419 branch December 6, 2024 13:40
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants