SNOW-1801434 add GUID to request in node.js driver #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. Added logs for node.js http client. Renamed utils file to comply with convention.
…bles. Fixed comments styling.
…quests made to snowflake using parameters to avoid changes in universal HttpClient
sfc-gh-fpawlowski
changed the base branch from
master
to
SNOW-1631790-Transport-Layer
sfc-gh-pfus
reviewed
Nov 19, 2024
sfc-gh-dszmolka
changed the title
sfc-gh-pmotacki
approved these changes
Nov 21, 2024
…t using connection config added.
…ters describing token prefixing it fixed.
…D-to-request-in-NODE.js-driver
…cted not to duplicate places used to pass the requestOptions.
…ithInterceptors to tests
…eptor classes added
…ection to test utils added
… in code request constructors and proxies
…g core.configure with passing HttpClient class
…D-to-request-in-NODE.js-driver
…mock to support guid
…mock to support guid
sfc-gh-pfus
approved these changes
Dec 5, 2024
sfc-gh-pmotacki
force-pushed
the
SNOW-1631790-Transport-Layer
branch
from
adb13c4 to
6c27246
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #965 +/- ##
==========================================
+ Coverage 88.80% 88.87% +0.06%
==========================================
Files 71 72 +1
Lines 6889 6911 +22
==========================================
+ Hits 6118 6142 +24
+ Misses 771 769 -2 ☔ View full report in Codecov by Sentry. |
…tting includeGuid flag implicitly in preprocessRequestOptions
…ed to ExcludeGuid
sfc-gh-fpawlowski
deleted the
SNOW-1801434-Add-GUID-to-request-in-NODE.js-driver
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Checklist
npm run lint:check -- CHANGED_FILESand fix problems in changed code)npm run test:unitandnpm run test:integration)