Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snow 1846395 improve url data sanitization #980

Merged
merged 58 commits into from
Dec 10, 2024
Merged

Snow 1846395 improve url data sanitization #980

merged 58 commits into from
Dec 10, 2024

Conversation

sfc-gh-fpawlowski
Copy link
Contributor

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the types in index.d.ts file (if necessary)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-fpawlowski
SNOW-1631790-Transport-Layer - Base HTTP client implemented
5d74303
@sfc-gh-fpawlowski
SNOW-1631790-Transport-Layer - Base http client logging splitted into…
4b2c001 
… utils and main
@sfc-gh-fpawlowski
SNOW-1631790-Transport-Layer - Removed absent parameters from the doc…
df6f773 
…s. Added logs for node.js http client. Renamed utils file to comply with convention.
@sfc-gh-fpawlowski
SNOW-1631790-Transport-Layer - Improved readability by renaming varia…
7725d96 
…bles. Fixed comments styling.
@sfc-gh-fpawlowski
SNOW-1801434-Add-GUID-to-request-in-NODE.js-driver - Added guid to re…
a858cb3 
…quests made to snowflake using parameters to avoid changes in universal HttpClient
@sfc-gh-fpawlowski
SNOW-1801434-Add-GUID-to-request-in-NODE.js-driver - Guid logging imp…
91628b1 
…roved.
@sfc-gh-fpawlowski
SNOW-1631790-Transport-Layer - missing logs added for browser client
c79c2fc
@sfc-gh-fpawlowski
SNOW-1801434-Add-GUID-to-request-in-NODE.js-driver: mock client adjus…
45c1bbe 
…ted for guid.
@sfc-gh-fpawlowski
SNOW-1631790-Transport-Layer: Partial Identification of the HttpClien…
e12d8ba 
…t using connection config added.
@sfc-gh-fpawlowski
SNOW-1631790-Transport-Layer: Proxy description added to logs
b45999d
@sfc-gh-fpawlowski
SNOW-1631790-Transport-Layer: Proxy redundant calls to getter eliminated
1d57d58
@sfc-gh-fpawlowski
Merge branch 'master' into SNOW-1631790-Transport-Layer
b734f52
@sfc-gh-fpawlowski
SNOW-1801434-Add-GUID-to-request-in-NODE.js-driver: Guid generated on…
bcc9628 
…ly when needed.
@sfc-gh-fpawlowski
SNOW-1631790-Transport-Layer: Masking Tokens for '%' signs and parame…
54d48e6 
…ters describing token prefixing it fixed.
@sfc-gh-fpawlowski
Merge branch 'master' into SNOW-1631790-Transport-Layer
fc5531c
@sfc-gh-fpawlowski
Merge branch 'master' into SNOW-1631790-Transport-Layer
8e8998b
@sfc-gh-fpawlowski
Merge branch 'SNOW-1631790-Transport-Layer' into SNOW-1801434-Add-GUI…
be0d198 
…D-to-request-in-NODE.js-driver
@sfc-gh-fpawlowski
SNOW-1801434-Add-GUID-to-request-in-NODE.js-driver: IncludeGuid extra…
eb94b72 
…cted not to duplicate places used to pass the requestOptions.
@sfc-gh-fpawlowski
SNOW-1801434-Add-GUID-to-request-in-NODE.js-driver: Added HttpClientW…
8d53d1a 
…ithInterceptors to tests
@sfc-gh-fpawlowski
SNOW-1801434-Add-GUID-to-request-in-NODE.js-driver: Fixed tests for GUID
cf39674
@sfc-gh-fpawlowski
SNOW-1801434-Add-GUID-to-request-in-NODE.js-driver: Formatting fix.
6029097
@sfc-gh-fpawlowski
Merge branch 'master' into SNOW-1631790-Transport-Layer
adb13c4
@sfc-gh-fpawlowski
SNOW-1801434-Add-GUID-to-request-in-NODE.js-driver: Tests with Interc…
69aee7b 
…eptor classes added
@sfc-gh-fpawlowski
SNOW-1801434-Add-GUID-to-request-in-NODE.js-driver: Core instance inj…
9674391 
…ection to test utils added
@sfc-gh-fpawlowski
SNOW-1801434-Add-GUID-to-request-in-NODE.js-driver: IncludeGuid added…
29a75a8 
… in code request constructors and proxies
@sfc-gh-fpawlowski
SNOW-1801434-Add-GUID-to-request-in-NODE.js-driver: Reverted extendin…
8acb7aa 
…g core.configure with passing HttpClient class
@sfc-gh-fpawlowski
Merge branch 'SNOW-1631790-Transport-Layer' into SNOW-1801434-Add-GUI…
691ede4 
…D-to-request-in-NODE.js-driver
@sfc-gh-fpawlowski
SNOW-1801434-Add-GUID-to-request-in-NODE.js-driver: Removed unused co…
fe9578b 
…mments
@sfc-gh-fpawlowski
SNOW-1801434-Add-GUID-to-request-in-NODE.js-driver: Fixed httpClient …
895e356 
…mock to support guid
@sfc-gh-fpawlowski
SNOW-1801434-Add-GUID-to-request-in-NODE.js-driver: Fixed httpClient …
d109f10 
…mock to support guid
@sfc-gh-fpawlowski sfc-gh-fpawlowski marked this pull request as ready for review December 6, 2024 12:55
@sfc-gh-fpawlowski sfc-gh-fpawlowski requested a review from a team as a code owner December 6, 2024 12:55
sfc-gh-pmotacki
sfc-gh-pmotacki requested changes Dec 6, 2024
View reviewed changes
lib/constants/sf_params.js Outdated Show resolved Hide resolved
lib/http/request_util.js Outdated Show resolved Hide resolved
lib/http/request_util.js Outdated Show resolved Hide resolved
test/unit/snowflake_test.js Show resolved Hide resolved
Base automatically changed from SNOW-1801434-Add-GUID-to-request-in-NODE.js-driver to master December 6, 2024 14:33
sfc-gh-pmotacki
sfc-gh-pmotacki requested changes Dec 6, 2024
View reviewed changes
lib/http/request_util.js Outdated Show resolved Hide resolved
sfc-gh-astachowski
sfc-gh-astachowski reviewed Dec 6, 2024
View reviewed changes
lib/http/request_util.js Show resolved Hide resolved
lib/logger/logging_util.js Show resolved Hide resolved
lib/http/request_util.js Outdated Show resolved Hide resolved
test/integration/testUtil.js Outdated Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit 85a6a39 into master Dec 10, 2024
54 of 57 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-1846395-Improve-URL-data-sanitization branch December 10, 2024 13:14
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-astachowski sfc-gh-astachowski sfc-gh-astachowski approved these changes

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

Assignees

@sfc-gh-fpawlowski sfc-gh-fpawlowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-fpawlowski @sfc-gh-pbulawa @sfc-gh-pmotacki @sfc-gh-astachowski