Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-761991 Update license header to 2023 #1481

Merged
merged 4 commits into from
Mar 17, 2023
Merged

SNOW-761991 Update license header to 2023 #1481

merged 4 commits into from
Mar 17, 2023

Conversation

sfc-gh-sfan
Copy link
Contributor

Description

It's 2023

Testing

N/A

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Description

It's 2023

Testing

N/A
@sfc-gh-sfan sfc-gh-sfan requested review from a team, sfc-gh-mkeller and sfc-gh-aalam and removed request for a team March 17, 2023 18:05
@sfc-gh-sfan
Copy link
Contributor Author

sfc-gh-sfan commented Mar 17, 2023

Interesting. My local precommit isort does not show these failure :/

@sfc-gh-aalam sfc-gh-aalam added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Mar 17, 2023
Copy link
Collaborator

@sfc-gh-aalam sfc-gh-aalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just found a couple of extra lines

src/snowflake/connector/feature.py Outdated Show resolved Hide resolved
test/integ/test_reuse_cursor.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #1481 (1067db4) into main (9008e2c) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1481      +/-   ##
==========================================
+ Coverage   81.90%   81.98%   +0.08%     
==========================================
  Files          60       60              
  Lines        8597     8597              
  Branches     1271     1271              
==========================================
+ Hits         7041     7048       +7     
+ Misses       1223     1217       -6     
+ Partials      333      332       -1     
Impacted Files Coverage Δ
src/snowflake/connector/__init__.py 100.00% <ø> (ø)
src/snowflake/connector/_sql_util.py 95.83% <ø> (ø)
src/snowflake/connector/arrow_context.py 80.24% <ø> (ø)
src/snowflake/connector/auth/__init__.py 100.00% <ø> (ø)
src/snowflake/connector/auth/_auth.py 70.89% <ø> (ø)
src/snowflake/connector/auth/by_plugin.py 88.31% <ø> (ø)
src/snowflake/connector/auth/default.py 94.73% <ø> (ø)
src/snowflake/connector/auth/idtoken.py 70.96% <ø> (ø)
src/snowflake/connector/auth/keypair.py 83.90% <ø> (ø)
src/snowflake/connector/auth/oauth.py 80.95% <ø> (ø)
... and 49 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-sfan sfc-gh-sfan merged commit 0894b78 into main Mar 17, 2023
@sfc-gh-sfan sfc-gh-sfan deleted the shixuan_license branch March 17, 2023 22:42
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants