SNOW-1763555 update how HTTP headers are requested from OpenTelemetry #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-mkeller
added
the
DO_NOT_PORT_CHANGES_TO_SP
sfc-gh-bdrutu
approved these changes
Nov 14, 2024
Co-authored-by: Bogdan Drutu <bogdan.drutu@snowflake.com>
sfc-gh-enie
approved these changes
Nov 14, 2024
sfc-gh-dyadav
approved these changes
Nov 14, 2024
sfc-gh-mkeller
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1763555: OpenTelemetry integration utterly breaks driver if using DataDog #2084
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
In this PR I fix an error where sometime injecting OpenTelemetry headers into our own causes Exceptions to be thrown.
(Optional) PR for stored-proc connector: