Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1361785 Run e2e jar tests with multiple Java versions #756

Merged
merged 2 commits into from
May 6, 2024

Conversation

sfc-gh-lsembera
Copy link
Contributor

@sfc-gh-lsembera sfc-gh-lsembera commented Apr 24, 2024

This PR runs e2e jar tests with all LTS Java versions on all supported clouds. Compilation always happens with Java 8. The e2e jar test has been enhanced to test all supported data types. Additionally, this PR integrates google format with the e2e jar test project, so some changes lines are just reformats.

@sfc-gh-lsembera sfc-gh-lsembera marked this pull request as ready for review April 24, 2024 18:38
@sfc-gh-lsembera sfc-gh-lsembera marked this pull request as draft April 24, 2024 19:01
@sfc-gh-lsembera sfc-gh-lsembera force-pushed the lse-java-versions branch 7 times, most recently from 0f3f755 to d15c060 Compare April 30, 2024 13:44
@sfc-gh-lsembera sfc-gh-lsembera changed the title NO-SNOW Test multiple Java versions SNOW-1361785 Run e2e jar tests with multiple Java versions May 3, 2024
@sfc-gh-lsembera sfc-gh-lsembera force-pushed the lse-java-versions branch 3 times, most recently from abd656f to a141b0b Compare May 3, 2024 09:39
@sfc-gh-lsembera sfc-gh-lsembera marked this pull request as ready for review May 3, 2024 14:11
Copy link
Contributor

@sfc-gh-tzhang sfc-gh-tzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

format.sh Show resolved Hide resolved
@sfc-gh-tzhang
Copy link
Contributor

Compilation always happens with Java 8. The e2e jar test has been enhanced to test all supported data types.

Do we want to verify compilation with other java versions as well?

@sfc-gh-lsembera
Copy link
Contributor Author

Do we want to verify compilation with other java versions as well?

@sfc-gh-tzhang I tried it within a timebox, but didn't get it working. It is not necessary, though, because customers will anyway use the SDK from Maven, which we always publish with Java 8.

@sfc-gh-lsembera sfc-gh-lsembera merged commit ab6b8d3 into master May 6, 2024
15 checks passed
@sfc-gh-lsembera sfc-gh-lsembera deleted the lse-java-versions branch May 6, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants