Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error log for flush task scheduling #760

Merged
merged 7 commits into from
May 15, 2024
Merged

Add error log for flush task scheduling #760

merged 7 commits into from
May 15, 2024

Conversation

sfc-gh-alhuang
Copy link
Contributor

Add error log for flush task scheduling. This could happen when getCachedMaxClientLagInMs throw cast exception when provided parameter is int not long.

@sfc-gh-alhuang sfc-gh-alhuang marked this pull request as ready for review May 7, 2024 18:28
@sfc-gh-alhuang sfc-gh-alhuang requested review from sfc-gh-tzhang and a team as code owners May 7, 2024 18:28
@sfc-gh-alhuang sfc-gh-alhuang reopened this May 7, 2024
@sfc-gh-alhuang sfc-gh-alhuang reopened this May 7, 2024
sfc-gh-tzhang
sfc-gh-tzhang approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-tzhang sfc-gh-tzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, otherwise lgtm, thanks!

src/main/java/net/snowflake/ingest/streaming/internal/FlushService.java Show resolved Hide resolved
src/main/java/net/snowflake/ingest/streaming/internal/FlushService.java Show resolved Hide resolved
@sfc-gh-alhuang sfc-gh-alhuang merged commit 5e93b3d into master May 15, 2024
15 checks passed
@sfc-gh-alhuang sfc-gh-alhuang deleted the alhuang-parameter-parse-fix branch May 15, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-tzhang sfc-gh-tzhang sfc-gh-tzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-alhuang @sfc-gh-tzhang