Set createdon in BlobMetadata and is_iceberg in Drop Channel request #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sfc-gh-hmadan
commented
Sep 29, 2024
sfc-gh-hmadan
commented
- Set createdOn on the blob Metadata, which can be used in the service to populate the FileRegistrationRequest
- Set is_iceberg in /channels/drop API payload since it gets validated the same way as open channel (where we do have the is_iceberg API available)
sfc-gh-hmadan
requested review from
sfc-gh-tzhang and
a team
as code owners
| @@ -142,7 +142,8 @@ static <T> Blob constructBlobAndMetadata( | |||
| chunkMetadataBuilder | |||
| .setMajorVersion(Constants.PARQUET_MAJOR_VERSION) | |||
| .setMinorVersion(Constants.PARQUET_MINOR_VERSION) | |||
| .setCreatedOn(0L) | |||
| // set createdOn in seconds | |||
| .setCreatedOn(System.currentTimeMillis() / 1000) | |||
There was a problem hiding this comment.
Why do we need this? Blobs already have create time in its property and its cheaper to get it there than to query metadata
There was a problem hiding this comment.
For having consistent metadata across XP-based DML inserts into iceberg tables and SDK-based inserts into iceberg tables.
sfc-gh-alhuang
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.