SNOW-1764301 Iceberg parquet file configuration #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -89,6 +95,8 @@ public ClientBufferParameters(SnowflakeStreamingIngestClientInternal clientInter | |||
| clientInternal != null | |||
| ? clientInternal.getInternalParameterProvider().isEnableValuesCount() | |||
| : InternalParameterProvider.ENABLE_VALUES_COUNT_DEFAULT; | |||
| this.enableDictionaryEncoding = | |||
There was a problem hiding this comment.
Not very satisfied by how there's now a proliferation of places that control runtime behavior :(
There's ParameterProvider, internalParameterProvider, clientBuferParameters, and some completely unnecesary defaulting for when clientInternal is null (it should never be not even in tests).
Tried to come up with a better answer but nothing that sticks and is relevant to your current PR.
As a followup whenever you have time i'd suggest first removing the null defaulting, remove the "isTestMode" thing from everywhere (fully doable after a round of changes I did for the ExternalVolume class). Lets see how things look after these two!
sfc-gh-hmadan
approved these changes
Oct 28, 2024
sfc-gh-alhuang
force-pushed
the
alhuang-zstd
branch
3 times, most recently
from
0eb347a
to
422ac86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes following change: