Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enableIcebergStreaming to telemetry calls #878

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

sfc-gh-hmadan
Copy link
Collaborator

adding the enableIcebergStreaming boolean flag to all telemetry service calls done by the SDK.
Marking many of the RequestBuilder ctors as Deprecated.

@sfc-gh-hmadan sfc-gh-hmadan requested review from sfc-gh-tzhang and a team as code owners October 29, 2024 22:04
@sfc-gh-hmadan sfc-gh-hmadan enabled auto-merge (squash) October 29, 2024 22:05
Copy link
Contributor

@sfc-gh-alhuang sfc-gh-alhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@sfc-gh-hmadan sfc-gh-hmadan merged commit e5c3316 into master Oct 31, 2024
47 checks passed
@sfc-gh-hmadan sfc-gh-hmadan deleted the hmadan-telemetry-isiceberg branch October 31, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants