Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Iceberg streaming merge gate #896

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

sfc-gh-alhuang
Copy link
Contributor

Setup merge gates for Iceberg streaming. For now we only supports AWS.

@sfc-gh-alhuang sfc-gh-alhuang requested review from sfc-gh-tzhang and a team as code owners November 8, 2024 22:56
@sfc-gh-alhuang sfc-gh-alhuang changed the base branch from master to alhuang-IT November 8, 2024 22:57
@sfc-gh-alhuang sfc-gh-alhuang force-pushed the alhuang-iceberg-gh-action branch from 92c8d34 to bff3432 Compare November 8, 2024 22:59
@sfc-gh-alhuang sfc-gh-alhuang force-pushed the alhuang-iceberg-gh-action branch 2 times, most recently from 0f529cd to 1a08882 Compare November 8, 2024 23:45
@sfc-gh-alhuang sfc-gh-alhuang force-pushed the alhuang-iceberg-gh-action branch from bdd4a99 to f007d6f Compare November 9, 2024 00:03
Base automatically changed from alhuang-IT to master November 9, 2024 00:24
@sfc-gh-alhuang sfc-gh-alhuang force-pushed the alhuang-iceberg-gh-action branch from f007d6f to 8050862 Compare November 9, 2024 00:29
@sfc-gh-alhuang sfc-gh-alhuang enabled auto-merge (squash) November 9, 2024 00:49
Copy link
Contributor

@sfc-gh-tzhang sfc-gh-tzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

run: mvn -DghActionsIT verify --batch-mode
run: |
mvn -DghActionsIT -D"failsafe.excludedGroups"="net.snowflake.ingest.IcebergIT" verify --batch-mode
build-iceberg:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a comment about why this is needed, as well as a TODO with this is temporary and can be consolidated in the future

@sfc-gh-alhuang sfc-gh-alhuang merged commit cd0be31 into master Nov 9, 2024
45 of 47 checks passed
@sfc-gh-alhuang sfc-gh-alhuang deleted the alhuang-iceberg-gh-action branch November 9, 2024 00:50
sfc-gh-alhuang added a commit that referenced this pull request Nov 9, 2024
sfc-gh-alhuang added a commit that referenced this pull request Nov 9, 2024
Revert "Introduce Iceberg streaming merge gate (#896)"

This reverts commit cd0be31.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants