Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-920999 add proxy tests using wiremock #1807

Merged
merged 14 commits into from
Jul 29, 2024
Merged

SNOW-920999 add proxy tests using wiremock #1807

merged 14 commits into from
Jul 29, 2024

Conversation

sfc-gh-akolodziejczyk
Copy link
Contributor

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk commented Jun 26, 2024 •
edited
Loading

Overview

SNOW-920999

Wiremock proxy tests are currently executed for java 11 & java 17. Wiremock no longer support java 8 and for java 21 generating needed certificates by wiremock is not supported yet. As Wiremock is run using standalone jar we can launch it for java 8 and 21 tests if we will install i.e. jre-11 on runners/images. (to discuss if we want to do it)
Due to stopped support for java 8 wiremock-standalone needs to be used, as wiremock java library will not compile for java8.
When connecting to Snowflake by https, https proxy is used, for local Snowflake environment http proxy is used.

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk changed the title SNOW-920999 SNOW-920999 add proxy tests using wiremock Jun 27, 2024
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk force-pushed the SNOW-920999 branch 7 times, most recently from e9d7f39 to 983481e Compare June 28, 2024 14:51
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk marked this pull request as ready for review June 28, 2024 14:51
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk requested a review from a team as a code owner June 28, 2024 14:51
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk force-pushed the SNOW-920999 branch 8 times, most recently from 538ca4d to 65748fd Compare July 18, 2024 16:12
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Jul 22, 2024
View reviewed changes
src/test/java/net/snowflake/client/RunningNotOnJava21.java Show resolved Hide resolved
src/test/java/net/snowflake/client/RunningNotOnGithubActionsMac.java Show resolved Hide resolved
src/test/java/net/snowflake/client/jdbc/ProxyLatestIT.java Outdated Show resolved Hide resolved
src/test/java/net/snowflake/client/jdbc/ProxyLatestIT.java Show resolved Hide resolved
src/test/java/net/snowflake/client/jdbc/ProxyLatestIT.java Outdated Show resolved Hide resolved
src/test/java/net/snowflake/client/jdbc/ProxyLatestIT.java Show resolved Hide resolved
src/test/java/net/snowflake/client/jdbc/ProxyLatestIT.java Outdated Show resolved Hide resolved
src/test/java/net/snowflake/client/jdbc/ProxyLatestIT.java Outdated Show resolved Hide resolved
src/test/java/net/snowflake/client/jdbc/ProxyLatestIT.java Outdated Show resolved Hide resolved
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk merged commit ce3d301 into master Jul 29, 2024
141 checks passed
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk deleted the SNOW-920999 branch July 29, 2024 10:06
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mhofman sfc-gh-mhofman sfc-gh-mhofman left review comments

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-akolodziejczyk @sfc-gh-dprzybysz @sfc-gh-pfus @sfc-gh-mhofman