Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snow-1213120-Reuse-Connections-1 #1815

Merged
merged 7 commits into from
Jul 19, 2024

Conversation

sfc-gh-ext-simba-jf
Copy link
Collaborator

Overview

SNOW-1213120

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

Changed tests to share connections where possible to decrease test runtime

@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf requested a review from a team as a code owner July 9, 2024 06:19
@sfc-gh-ext-simba-jf
Copy link
Collaborator Author

I had to add the change to BaseJDBCTest in all the PR's so the build wouldn't fail, but once the first PR is merged I will rebase the other's and remove the BaseJDBCTest changes in those.

that don't need the shared connection field, failing when they don't
have the proper connection parameters.
@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 6c2485d into master Jul 19, 2024
272 of 273 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the Snow-1213120-Reuse-Connections-1 branch July 19, 2024 08:57
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants