Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1831140 E2e tests of Iceberg JSON ingestion #1013

Merged
merged 1 commit into from
Dec 3, 2024
Merged

SNOW-1831140 E2e tests of Iceberg JSON ingestion #1013

merged 1 commit into from
Dec 3, 2024

Conversation

sfc-gh-mbobowski
Copy link
Contributor

@sfc-gh-mbobowski sfc-gh-mbobowski commented Dec 2, 2024 •
edited
Loading

Overview

SNOW-1831140

A solid contribution to iceberg JSON e2e's + some minor bugs fixes.

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

sfc-gh-mbobowski
sfc-gh-mbobowski commented Dec 2, 2024
View reviewed changes
src/main/java/com/snowflake/kafka/connector/internal/streaming/DirectTopicPartitionChannel.java
@@ -337,7 +337,7 @@ public void insertRecord(SinkRecord kafkaSinkRecord, boolean isFirstRowPerPartit
// Simply skip inserting into the buffer if the row should be ignored after channel reset
if (needToSkipCurrentBatch) {
LOGGER.info(
"Ignore adding offset:{} to buffer for channel:{} because we recently reset offset in"
"Ignore inserting offset:{} for channel:{} because we recently reset offset in"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no buffer anymore so this log was misleading.

@sfc-gh-mbobowski sfc-gh-mbobowski marked this pull request as ready for review December 2, 2024 16:17
@sfc-gh-mbobowski sfc-gh-mbobowski requested a review from a team as a code owner December 2, 2024 16:17
sfc-gh-achyzy
sfc-gh-achyzy approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-achyzy sfc-gh-achyzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-mbobowski sfc-gh-mbobowski merged commit c16d13d into master Dec 3, 2024
53 of 54 checks passed
@sfc-gh-mbobowski sfc-gh-mbobowski deleted the mbobowski-SNOW-1831140-json-schema-evolution-e2e branch December 3, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-achyzy sfc-gh-achyzy sfc-gh-achyzy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-mbobowski @sfc-gh-achyzy