[SNOW-665920] Add warnings in build script to prevent a privately built jar from going to the customer #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-rcheng
requested review from
sfc-gh-japatel,
sfc-gh-rramachandran,
sfc-gh-mnaides,
sfc-gh-tzhang and
sfc-gh-tjones
as code owners
|
New message at end of build looks like this: |
Codecov Report
@@ Coverage Diff @@
## master #492 +/- ##
=======================================
Coverage 87.11% 87.11%
=======================================
Files 47 47
Lines 3957 3957
Branches 418 418
=======================================
Hits 3447 3447
Misses 348 348
Partials 162 162 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sfc-gh-rcheng
added a commit
that referenced
this pull request
Nov 7, 2022
* Add docker setup resources to the kafka connect repo (#483) * initial docker setup info * blank connectors and rename container folder * ignore connector example json files * more .gitignore setup maybe? * example files * template folder * clean up misc * remove volume bind, allow install sfkc 1.8.1 * yml changes * remove empty lines * Fix docker-setup yml files (#490) * docker wont pull from /usr/ * git ignore test * readme * test gitignore * remove yml files from gitignore * test force add * i think gitignore works now * need to add it back in for changes lol * add back jmx * SNOW-625820: multiple fixes for KC schematization schema mapping (#488) - Update the config key word from enable.schematization to snowflake.enable.schematization - Remove some duplicate constants - Fix a null pointer exception during channel closing - Update the column name format function to return the quoted column name * [SNOW-594195] Add correlationId to logging (#487) * smh static doesnt work * logginghandler with static cid, logging -> enablelogging * test gitignore * passes tests * corrid at beginning * remove yml files from git cache * add yml, copyright; change logger class name * ran formatter * remove wildcard imports * added logging handler tests * review changes * formatter * NO-SNOW: Put rows with JsonProcessingException into the DLQ instead of ignoring them (#491) Put rows with JsonProcessingException into the DLQ instead of ignoring them * [SNOW-643653] Fix Citi Blackduck vulnerabilities (#497) * avro 1.8.1 -> 1.11.0, kakfa-clients -> 2.8.2 * vulnerabilities fixed? * fixed all vuln * [SNOW-665920] Add warnings in build script to prevent a privately built jar from going to the customer (#492) * do as i say not as i do * change warn and mkdir docker jar folder * [SNOW-665898] Add log granularity instance id logging for Task (#495) * refactor to kcglobalinstanceid * parse instance id * ut pass - til final doesnt let injectmocks * tests pass, need cc * cc 100 * added logging to task * spacing issue in logs * formatter * formatter and rerun failed tests? * set task instance id in start * utils string format * task functionality * can someone say overengineer oops * no one likes overenegineering * 100 cc * added int test, maybe need to merge other branch? * remove fallbackid.. weird and not needed for task * working on int test * added it * stash * it done * formatter * formatter again * remove start count and fix it * format * add open count and some pr nits * formatting is a pain * change starttime and import * use uuid+time for instanceid * Modify Codeowners (#494) * SNOW-630885: Support schema evolution with schematization (#501) This PR adds support to do schema evolution through ALTER TABLE command when there is schema mismatch between the kafka message and the table schema * Bump protobuf-java from 3.19.4 to 3.19.6 in /test/test_data/protobuf (#499) Bumps [protobuf-java](https://github.com/protocolbuffers/protobuf) from 3.19.4 to 3.19.6. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/generate_changelog.py) - [Commits](protocolbuffers/protobuf@v3.19.4...v3.19.6) --- updated-dependencies: - dependency-name: com.google.protobuf:protobuf-java dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * SNOW-686528: Check schema evolution table option (#509) - We always enable schema evolution for tables that are created by KC - Check for schema evolution table option before updating the schema * SNOW-506446: [Snyk] Security upgrade com.fasterxml.jackson.core:jackson-databind from 2.13.2.1 to 2.13.4.2 (#503) * fix: pom.xml to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-3038426 * added to confluent pom as well Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: revi cheng <revi.cheng@snowflake.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Toby Zhang <toby.zhang@snowflake.com> Co-authored-by: Jay Patel <jay.patel@snowflake.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sfc-gh-snyk-sca-sa <95290361+sfc-gh-snyk-sca-sa@users.noreply.github.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I sent a privately built jar to customer support for testing and didn't realize until after the customer received the jar that it was a mistake. Adding a comment in the build script to prevent future similar mistakes