Single quotes for the COLLATE statement #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sfc-gh-stakeda did I file it wrong? |
|
@sfc-gh-mkeller FYI. |
|
@sfc-gh-mkeller did I file it wrong? |
|
No @Stamper , I just didn't have time to look at this yet. |
|
@Stamper is it okay if I take this over and write some tests? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we can see in the snowflake docs the COLLATE statement requires single quotes for the collation specification.
In case of running CREATE TABLE script with double quotes in the Snowflake Console it returns the result like
SQL compilation error: syntax error line 3 at position 24 unexpected '"SQL_Latin1_General_CP1_CI_AS"'.After this PR
sqlalchemy.schema.CreateTable(some_table).compilewithdialect=snowflake.sqlalchemy.snowdialect.dialect()will return i.e.name NCHAR(10) COLLATE 'SQL_Latin1_General_CP1_CI_AS'instead ofname NCHAR(10) COLLATE "SQL_Latin1_General_CP1_CI_AS"This PR just overriding _render_string_type method from SQLAlchemy GenericTypeCompiler class for Snowflake SQLAlchemy dialect.
Tested with Python 3.8.2