[Test PR] SNOW-892284: Fix boolean parameter parsing from URL query #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
cache_column_metadata is a snowflake-sqlalchemy argument, not a snowflake-connector-python argument so it should be set and ommitted from the arguments list before the call to the connector is made.
|
Missing a CI run approval at the moment 😞 |
|
Continuing from the thread in #439 (can't post comments in closed PRs): sure, we can merge this PR, though at the moment it requires a review approval 😄 |
sfc-gh-stan
changed the title
sfc-gh-stan
requested review from
sfc-gh-aling,
a team and
sfc-gh-jdu
and removed request for
a team
|
Requested approvals from @sfc-gh-aling and @snowflakedb/snowpark-python-api. |
sfc-gh-sfan
reviewed
Oct 12, 2023
| ) | ||
|
|
||
| for name, value in query.items(): |
There was a problem hiding this comment.
I don't think I understand what this for-loop is doing, can you elaborate?
There was a problem hiding this comment.
We grab the parameter to type mapping used in validation of the driver arguments to figure out what are the expected types of each argument, then we pass the value to the driver according to these rules:
- if the parameter is not found in the type mapping, pass it through as a string
- if the expected type is
str, pass it through as a string - if the expected type is
bool, parse it and pass as a boolean - if it's some other type, pass it through as a string
There was a problem hiding this comment.
Thanks for the clarification. Let's maybe add it into the comment? :)
sfc-gh-sfan
approved these changes
Oct 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #439, which was closed accidentally.