Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1844094: Skip optimization if error is raised during optimization stage #2710

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typing issues
  • Loading branch information
sfc-gh-aalam committed Dec 4, 2024
commit 2b42c4936468be962f977509b7ecd8f4f082eac9
Original file line number Diff line number Diff line change
@@ -88,8 +88,8 @@ def compile(self) -> Dict[PlanQueryType, List[Query]]:
}

if self.should_start_query_compilation():
session = self._plan.session
try:
session = self._plan.session
# preparation for compilation
# 1. make a copy of the original plan
start_time = time.time()
4 changes: 2 additions & 2 deletions src/snowflake/snowpark/_internal/telemetry.py
Original file line number Diff line number Diff line change
@@ -483,7 +483,7 @@ def send_query_compilation_summary_telemetry(
self.send(message)

def send_query_compilation_stage_failed_telemetry(
self, session_id: int, plan_uuid: str, error_type: str, error_str: str
self, session_id: int, plan_uuid: str, error_type: str, error_message: str
) -> None:
message = {
**self._create_basic_telemetry_data(
@@ -493,7 +493,7 @@ def send_query_compilation_stage_failed_telemetry(
TelemetryField.SESSION_ID.value: session_id,
CompilationStageTelemetryField.PLAN_UUID.value: plan_uuid,
CompilationStageTelemetryField.ERROR_TYPE.value: error_type,
CompilationStageTelemetryField.ERROR_MESSAGE.value: error_str,
CompilationStageTelemetryField.ERROR_MESSAGE.value: error_message,
},
}
self.send(message)