Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specific roles as secondary roles #2762

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vkcelik
Copy link

@vkcelik vkcelik commented Dec 13, 2024

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    We needed to use specific roles as secondary roles but this was not supported, so I added support for it. No Jira issue

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.
    The "USE SECONDARY ROLES" command has support for one or more specific roles but it was not supported in the use_secondary_roles method. This PR adds support for it.

@vkcelik vkcelik marked this pull request as ready for review December 13, 2024 13:34
@vkcelik vkcelik requested review from a team as code owners December 13, 2024 13:34
@vkcelik vkcelik changed the title Add support for list of specific roles as secondary roles Add support specific roles as secondary roles Dec 13, 2024
@vkcelik vkcelik changed the title Add support specific roles as secondary roles Add support for specific roles as secondary roles Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant