SNOW-770051 Fix a wrong result issue for crossing schema join/union #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #504 +/- ##
=======================================
Coverage 89.58% 89.59%
=======================================
Files 52 52
Lines 4475 4487 +12
Branches 676 744 +68
=======================================
+ Hits 4009 4020 +11
- Misses 466 467 +1 |
sfc-gh-mrui
commented
Apr 20, 2023
| @@ -163,6 +164,18 @@ private[querygeneration] class QueryBuilder(plan: LogicalPlan) { | |||
| expression.children.foreach(processExpression(_, statisticSet)) | |||
| } | |||
|
|
|||
| private def canUseSameConnection(snowflakeQueries: Seq[SnowflakeQuery]): Boolean = { | |||
| val sourceParameters: Seq[ConnectionCacheKey] = snowflakeQueries.flatMap(_.getSourceQueries) | |||
| .map(x => new ConnectionCacheKey(x.relation.params)) | |||
There was a problem hiding this comment.
Reuse the Connection sharable check criteria for Can-Join-or-Union.
| @@ -89,6 +92,18 @@ private[querygeneration] abstract sealed class SnowflakeQuery { | |||
| } | |||
| } | |||
|
|
|||
| private[querygeneration] | |||
There was a problem hiding this comment.
Introduce UnarySnowflakeQuery and BinarySnowflakeQuery for code reuse.
Logically, we may introduce LeafSnowflakeQuery and MultipleChildrenSnowflakeQuery.
But it sounds not necessary because SourceQuery and Union are the only classes belong to them.
So just enhance SourceQuery and Union to implement it.
| @@ -362,6 +379,9 @@ case class UnionQuery(children: Seq[LogicalPlan], | |||
| new QueryBuilder(child).treeRoot | |||
| } | |||
|
|
|||
| override def getSourceQueries: Seq[SourceQuery] = | |||
| queries.flatMap(_.getSourceQueries) | |||
|
|
|||
There was a problem hiding this comment.
PS: Spark Union can have multiple children. FYI.
sfc-gh-mrui
changed the title
sfc-gh-mrui
requested review from
sfc-gh-sshankar,
sfc-gh-ema and
sfc-gh-bli
as code owners
sfc-gh-ema
approved these changes
Apr 20, 2023
sfc-gh-bli
reviewed
Apr 21, 2023
| private def canUseSameConnection(snowflakeQueries: Seq[SnowflakeQuery]): Boolean = { | ||
| val sourceParameters: Seq[ConnectionCacheKey] = snowflakeQueries.flatMap(_.getSourceQueries) | ||
| .map(x => new ConnectionCacheKey(x.relation.params)) | ||
| sourceParameters.forall(sourceParameters.head.equals(_)) |
arthurli1126
pushed a commit
to arthurli1126/spark-snowflake
that referenced
this pull request
Jul 23, 2023
…nowflakedb#504) * SNOW-770051 Fix a potential wrong result issue for crossing schema join/union * Revise error message * Simplify canUseSameConnection() * Use toSet.size == 1 for duplication check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNOW-770051 Fix a wrong result issue for crossing schema join/union
The design doc is:
https://docs.google.com/document/d/1Xl8wB5YUMmldftpWIMy9WUm4AfeQoS28bP8ZlPU95lw/edit#heading=h.wmwy5v8eykqd