Skip to content
This repository has been archived by the owner on Aug 2, 2020. It is now read-only.

Drop GccLtXX flags, require GCC > 4.7 and up #450

Merged
merged 1 commit into from
Nov 7, 2017
Merged

Drop GccLtXX flags, require GCC > 4.7 and up #450

merged 1 commit into from
Nov 7, 2017

Conversation

izgzhen
Copy link
Collaborator

@izgzhen izgzhen commented Nov 7, 2017

See #449.

@snowleopard
Copy link
Owner

snowleopard commented Nov 7, 2017

@izgzhen Thanks for the patch!

Looks like you haven't removed all uses of the flags, so Hadrian can't be compiled.

@izgzhen
Copy link
Collaborator Author

izgzhen commented Nov 7, 2017

Looks like you haven't removed all uses of the flags, so Hadrian can't be compiled.

Yes! I was in a hurry at the time of making this PR, sorry.

@snowleopard
Copy link
Owner

snowleopard commented Nov 7, 2017

@izgzhen Thanks, we're past the compilation stage now :)

We now hit GHC panic:

Stderr:
ghc: panic! (the 'impossible' happened)
  (GHC version 8.0.2 for x86_64-unknown-mingw32):
	tcIfaceGlobal (local): not found
  You are in a maze of twisty little passages, all alike.
  While forcing the thunk for TyThing SyntaxExpr
  which was lazily initialized by initIfaceTcRn,
  I tried to tie the knot, but I couldn't find SyntaxExpr
  in the current type environment.
  If you are developing GHC, please read Note [Tying the knot]
  and Note [Type-checking inside the knot].
  Consider rebuilding GHC with profiling for a better stack trace.
  Contents of current type environment: []
Please report this as a GHC bug:  http://www.haskell.org/ghc/reportabug
)

:-S Presumably GHC is broken? Or did we break it by a strange combination of flags?

@snowleopard
Copy link
Owner

Ah, wait, this is bootstrapping GHC! So, it's a real bug which we somehow triggered by flags.

@izgzhen
Copy link
Collaborator Author

izgzhen commented Nov 7, 2017

Ah, wait, this is bootstrapping GHC! So, it's a real bug which we somehow triggered by flags.

O_o interesting

@snowleopard
Copy link
Owner

@izgzhen One possible explanation is that this GHC commit:

ghc/ghc@0ff152c

Changed compiler/hsSyn/HsExpr.hs in such a way that it started to trigger an old GHC bug. It's therefore not the fault of this PR.

@snowleopard snowleopard merged commit 5ebb69a into snowleopard:master Nov 7, 2017
@snowleopard
Copy link
Owner

snowleopard commented Nov 7, 2017

OK, I've confirmed this and merged the PR. GHC appears to be currently broken when bootstrapping with GHC 8.0.2.

@bgamari Shall I report this or is this a known issue?

@bgamari
Copy link
Collaborator

bgamari commented Nov 7, 2017 via email

@izgzhen izgzhen deleted the fix-gcc-lt branch April 3, 2018 04:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants