Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDB Shredder: align PostgresConstraints with atomic.events 0.10.0 #103

Closed
knservis opened this issue May 29, 2018 · 3 comments
Closed

RDB Shredder: align PostgresConstraints with atomic.events 0.10.0 #103

knservis opened this issue May 29, 2018 · 3 comments
Assignees
Labels
Milestone

Comments

@knservis
Copy link

knservis commented May 29, 2018

This should be happening automatically. I believe we should have a new issue where we generate this somehow from the atomic events schema, which can be found here:
https://github.com/snowplow/snowplow/blob/master/4-storage/redshift-storage/sql/atomic-def.sql

This has caused temporary (recoverable) loss of data after the atomic.events field lengths were changed.

@chuwy
Copy link
Contributor

chuwy commented May 29, 2018

Hey @alexanderdean, from my POV this is blocking whole PII enrichment feature. Should it be a part of R29?

@chuwy chuwy added this to the Release 29 milestone May 29, 2018
@chuwy
Copy link
Contributor

chuwy commented May 29, 2018

Prioritized to R29.

@chuwy chuwy changed the title RDB Shredder: align PostgresConstraints with latest atomic events RDB Shredder: align PostgresConstraints with atomic.events 0.10.0 May 29, 2018
@chuwy
Copy link
Contributor

chuwy commented May 29, 2018

Total 10 constraints were widened, which means Shredder probably silently truncated several other fields (less important though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants