Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmrEtlRunner: fix breaking get_assets spec #1287

Closed
fblundun opened this issue Jan 7, 2015 · 1 comment
Closed

EmrEtlRunner: fix breaking get_assets spec #1287

fblundun opened this issue Jan 7, 2015 · 1 comment
Assignees

Comments

@fblundun
Copy link
Contributor

fblundun commented Jan 7, 2015

This is the current output:

Failures:

  1) Snowplow::EmrEtlRunner::EmrJob returns the Hadoop assets
     Failure/Error: EmrJob.get_assets("s3://hadoop-assets/", "1.0.0").should == {
     ArgumentError:
       wrong number of arguments (2 for 3)
     # ./lib/snowplow-emr-etl-runner/emr_job.rb:444:in `get_assets'
     # ./spec/snowplow-emr-etl-runner/emr_job_spec.rb:31:in `block (2 levels) in <top (required)>'

Finished in 0.00503 seconds
6 examples, 1 failure

Failed examples:

rspec ./spec/snowplow-emr-etl-runner/emr_job_spec.rb:30 # Snowplow::EmrEtlRunner::EmrJob returns the Hadoop assets

It looks like the fact that get_assets now expects a Hadoop Shred version argument has broken the test.

@alexanderdean
Copy link
Member

Thanks for spotting this Fred!

@alexanderdean alexanderdean self-assigned this Jan 7, 2015
@alexanderdean alexanderdean added this to the Hadoop monitoring 1 milestone Jan 7, 2015
@alexanderdean alexanderdean changed the title EmrEtlRunner: fix test suite EmrEtlRunner: fix breaking get_assets spec Mar 9, 2015
peel pushed a commit to snowplow/emr-etl-runner that referenced this issue May 26, 2020
peel pushed a commit to snowplow/emr-etl-runner that referenced this issue May 28, 2020
peel pushed a commit to snowplow/emr-etl-runner that referenced this issue May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants