Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala Common Enrich: fix EtlPipeline short-circuiting on a first bad row #4320

Closed
chuwy opened this issue Apr 14, 2020 · 0 comments
Closed

Scala Common Enrich: fix EtlPipeline short-circuiting on a first bad row #4320

chuwy opened this issue Apr 14, 2020 · 0 comments
Assignees
@chuwy
Milestone
R119 (Automigrati...

Comments

@chuwy
Copy link
Contributor

chuwy commented Apr 14, 2020

A bug introduced in R118 (though before it was not possible) that processEvents short-circuits list processing because of traverse on EitherT.

As a result if payload contained two events: one that would go into bad and another into good bucket - we were having only single bad row.
@chuwy chuwy added the bug label Apr 14, 2020
@chuwy chuwy self-assigned this Apr 14, 2020
chuwy added a commit that referenced this issue Apr 14, 2020
@chuwy
Scala Common Enrich: fix EtlPipeline short-circuiting on a first bad …
30ff2a3 
…row (close #4320)
benjben pushed a commit that referenced this issue Apr 15, 2020
@chuwy @benjben
Scala Common Enrich: fix EtlPipeline short-circuiting on a first bad …
7ee9251 
…row (close #4320)
benjben pushed a commit that referenced this issue Apr 15, 2020
@chuwy @benjben
Scala Common Enrich: fix EtlPipeline short-circuiting on a first bad …
3a9f822 
…row (close #4320)
benjben pushed a commit that referenced this issue Apr 15, 2020
@chuwy @benjben
Scala Common Enrich: fix EtlPipeline short-circuiting on a first bad …
689a697 
…row (close #4320)
benjben pushed a commit that referenced this issue Apr 15, 2020
@chuwy @benjben
Scala Common Enrich: fix EtlPipeline short-circuiting on a first bad …
d7810ce 
…row (close #4320)
benjben pushed a commit that referenced this issue Apr 15, 2020
@chuwy @benjben
Scala Common Enrich: fix EtlPipeline short-circuiting on a first bad …
0c32abb 
…row (close #4320)
oguzhanunlu pushed a commit to snowplow/common-enrich that referenced this issue May 29, 2020
@chuwy @oguzhanunlu
Fix EtlPipeline short-circuiting on a first bad row (close snowplow/s…
51a797f 
…nowplow#4320)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chuwy chuwy

Labels
None yet
Projects
None yet
Milestone
R119 (Automigrations and bad rows imp...
Development

No branches or pull requests
1 participant
@chuwy