Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit valid bad rows for size violation and generic error #113

Closed
dilyand opened this issue Jan 28, 2021 · 0 comments
Closed

Emit valid bad rows for size violation and generic error #113

dilyand opened this issue Jan 28, 2021 · 0 comments
Milestone

Comments

@dilyand
Copy link
Contributor

dilyand commented Jan 28, 2021

The stream collector can generate two types of bad rows: size violations and generic errors (when dealing with an illegal querystring).

Currently, it is only writing out the data component of the bad row, which makes the record an invalid self-describing JSON.

Example:

{
  "processor": {
    "artifact": "snowplow-stream-collector",
    "version": "2.1.0"
  },
  "failure": {
    "timestamp": "2021-01-28T12:44:08.953Z",
    "errors": [
      "IllegalQueryString"
    ]
  },
  "payload": ""
}

should be:

{
  "schema": "iglu:com.snowplowanalytics.snowplow.badrows/generic_error/jsonschema/1-0-0",
  "data": {
    "processor": {
      "artifact": "snowplow-stream-collector",
      "version": "2.1.0"
    },
    "failure": {
      "timestamp": "2021-01-28T12:44:08.953Z",
      "errors": [
        "IllegalQueryString"
      ]
    },
    "payload": ""
  }
}
@dilyand dilyand added this to the 2.1.1 milestone Jan 28, 2021
@dilyand dilyand changed the title Common: emit valid bad rows for size violation and generic error Emit valid bad rows for size violation and generic error Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant