Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate BadRow if querystring cannot be parsed #73

Closed
dilyand opened this issue Oct 1, 2020 · 0 comments
Closed

Generate BadRow if querystring cannot be parsed #73

dilyand opened this issue Oct 1, 2020 · 0 comments
Assignees
Milestone

Comments

@dilyand
Copy link
Contributor

dilyand commented Oct 1, 2020

In CollectorService.cookie we have:

val queryParams = Uri.Query(queryString).toMap

which can throw an IllegalUriException if the qs cannot be parsed. Currently, we're silently dropping these payloads. It would be better to generate a BadRow so that users are alerted about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant