-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast logger migration #274
Merged
Merged
Changes from 46 commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
53bcb66
Add rotate log config option
RiugaBachi d2e30d6
Add monad-logger and fast-logger deps
RiugaBachi 38897c4
Remove (unused)
RiugaBachi 194015e
Update `RotatingLog` to wrap a FastLogger and its release callback
RiugaBachi 1a6e828
Add defaultRotationSpec
RiugaBachi f6ca7cc
Update imports/exports
RiugaBachi 7e3ed8c
Refactor withLogger to use a FastLogger to rotating files or stderr
RiugaBachi db54ccc
Update withRotatingLogger to use a FastLogger to a rotating file
RiugaBachi 6805a6e
Rename for clarity
RiugaBachi 2f7c736
Change addHunk to fast logging function
RiugaBachi 7cfb8fc
Change rotating log close fn
RiugaBachi 1e5c35d
Add yaml parsing for rotate-logs
RiugaBachi 29a673f
Update changelog
RiugaBachi ab6cf90
Fix typo
RiugaBachi 8306f4c
Added log name change examples for apps
RiugaBachi 2c2dbd0
Implement KeterM monad
RiugaBachi 954411b
Add unliftio-core dependency
RiugaBachi 397aed8
Expose Keter.Context
RiugaBachi c0e9dc8
Refactor Keter.Main to use KeterM
RiugaBachi 1725181
Refactor Keter.App to use KeterM
RiugaBachi 801e0e4
Refactor Keter.AppManager to use KeterM
RiugaBachi 839700f
Refactor Keter.Cli to use KeterM
RiugaBachi 8fc1dd1
Remove `ascLog` field (unused)
RiugaBachi c0a668f
Remove again
RiugaBachi b51b51d
Refactor Keter.HostManager to use KeterM
RiugaBachi 7b9ec22
Refactor Keter.PortPool to use KeterM
RiugaBachi 7833c71
Refactor Keter.Proxy to use KeterM (where possible)
RiugaBachi 8b5e0e3
Update monitorProcess logger callback to include log level
RiugaBachi 147e1ab
Remove old log message ADT
RiugaBachi 10c6762
Deprecate old exception logger for now
RiugaBachi ed22d6c
Stub out parts of test suite that broke for now
RiugaBachi 8f04804
Fix breaking changes in test suite
RiugaBachi 3dc60b2
Update test suite build dependencies
RiugaBachi 5eb0eff
Bump to version 2.1.0
RiugaBachi dbcf03d
Update changelog
RiugaBachi 85f1c88
Minor reformat
RiugaBachi fb78544
Create logging directory if missing
RiugaBachi f6583f1
Add to config template
RiugaBachi e464cfb
Lowercase
RiugaBachi fad5525
Rename RotatingLog to Logger
RiugaBachi 51785cf
Move logger creation to `createLoggerViaConfig`
RiugaBachi 60cf7cc
Documentation
RiugaBachi 7b9b79b
Use createLoggerViaConfig
RiugaBachi cb7d5a6
Imports
RiugaBachi 7887b89
Rename rotating log references
RiugaBachi 921cea2
Use `createLoggerViaConfig`
RiugaBachi bb6bfd3
Add blog post link to `KeterM` doc
RiugaBachi 8ed4fe5
Add 'keter|' tag to internal log format
RiugaBachi 07337ed
Remove `LogLevel` from process monitor log fn
RiugaBachi d586327
Refactor app & process-monitor log format
RiugaBachi dd1b71c
Imports
RiugaBachi 02c0623
Unquote app name
RiugaBachi 15a6cfd
Fix keter tag
RiugaBachi 95cef93
Remove `logEx`
RiugaBachi 5b47603
Remove todo
RiugaBachi a6bb6a4
Reintroduce commented out log calls
RiugaBachi 6847ba4
Add upper dependency bounds
RiugaBachi 3255e86
Rename LogFile to Log
RiugaBachi 8a18651
Move Keter.Conduit.LogFile to Keter.Logger
RiugaBachi 40fcca6
Update exposed modules
RiugaBachi fd4905c
Rename imports
RiugaBachi cd9e110
Store LogType in Logger
RiugaBachi aa22c8d
Update format comment
RiugaBachi 57f5c0d
Refactor log formatter to emit tags only when logging to stderr
RiugaBachi d58364f
Refactor to use formatTag
RiugaBachi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
Cabal-version: >=1.10 | ||
Name: keter | ||
Version: 2.0.1 | ||
Version: 2.1.0 | ||
Synopsis: Web application deployment manager, focusing on Haskell web frameworks | ||
Description: | ||
Deployment system for web applications, originally intended for hosting Yesod | ||
|
@@ -62,6 +62,9 @@ Library | |
, attoparsec >= 0.10 | ||
, http-client >= 0.5.0 | ||
, http-conduit >= 2.1 | ||
, fast-logger | ||
, monad-logger | ||
, unliftio-core | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess we should add upper bounds There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
, case-insensitive | ||
, array | ||
, mtl | ||
|
@@ -95,6 +98,7 @@ Library | |
Keter.AppManager | ||
Keter.LabelMap | ||
Keter.Cli | ||
Keter.Context | ||
Keter.Main | ||
Keter.PortPool | ||
Keter.Proxy | ||
|
@@ -124,6 +128,8 @@ test-suite test | |
type: exitcode-stdio-1.0 | ||
build-depends: base | ||
, transformers | ||
, mtl | ||
, monad-logger | ||
, conduit | ||
, bytestring | ||
, unix | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does this work with several apps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a typo here actually 🙏 Added some examples for app log changes just now.