adding first filler tests #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstore tests 8,9,11,12,13
|
currently running against https://github.com/snreynolds/go-ethereum/tree/eip1153 through retesteth |
winsvega
reviewed
Jun 30, 2022
src/GeneralStateTestsFiller/stExample/01_tloadBeginningTxnFiller.yml
Outdated
Show resolved
Hide resolved
winsvega
reviewed
Jun 30, 2022
| # | ||
| # Expect storage slot 1 to have value 88 | ||
|
|
||
| 02_tloadAfterStore: |
There was a problem hiding this comment.
tload after tstore
tload after store would be a case to check that store does not affect tload on the same address
There was a problem hiding this comment.
right, updated this test and added a new test #18
winsvega
reviewed
Jun 30, 2022
src/GeneralStateTestsFiller/stExample/03_tloadAfterStoreIs0Filler.yml
Outdated
Show resolved
Hide resolved
winsvega
reviewed
Jun 30, 2022
| @@ -0,0 +1,63 @@ | |||
| # 03 | |||
| # Loading any other slot after storing to a slot returns 0: TSTORE(x, y), TLOAD(x + n) where n > 0 returns 0 | |||
There was a problem hiding this comment.
hm. from math point of view you have to loop from 1 to 2**256 to prove that. just noting. I dont think it is reasonable. we can only pin point test
There was a problem hiding this comment.
thats true, updated the comment
winsvega
reviewed
Jun 30, 2022
src/GeneralStateTestsFiller/stExample/05_tloadReentrancyFiller.yml
Outdated
Show resolved
Hide resolved
winsvega
reviewed
Jun 30, 2022
src/GeneralStateTestsFiller/stExample/05_tloadReentrancyFiller.yml
Outdated
Show resolved
Hide resolved
ullashb
approved these changes
Aug 4, 2022
ullashb
approved these changes
Aug 4, 2022
snreynolds
force-pushed
the
filler-tests
branch
from
b34db6b
to
bc0dcbc
Compare
snreynolds
force-pushed
the
filler-tests
branch
from
6a5435d
to
fcd3575
Compare
move stEIP1153/bcEIP1153 into EIPTests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.