Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/collection: migrate modules to pkgs.formats #23

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

nezia1
Copy link
Collaborator

@nezia1 nezia1 commented Mar 4, 2025

This PR brings the ghostty and vscode module to be more in line with the others, i.e. use pkgs.formats generators instead, which provide a very convenient type as well as a generate function, which we can directly set as the file source.

Please keep in mind that this brings slightly breaking changes for ghostty, as keybinds cannot be defined like this anymore:

              keybind = {
                "${prefix}>c" = "new_tab";
                "${prefix}>p" = "move_tab:-1";
                "${prefix}>n" = "move_tab:1";
              };

But instead have to be defined as such (akin to home-manager):

              keybind = [
                "${prefix}>c=new_tab"
                "${prefix}>p=move_tab:-1"
                "${prefix}>n=move_tab:1"
              ];

This will be the case for every nested key-value pairs.

PS: @Lunarnovaa since I do not use VSCode, could you please test it to see if it works as expected? It shouldn't be an issue, but I'd like to make sure regardless.

Copy link
Collaborator

@Lunarnovaa Lunarnovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will test at home later but LGTM

@Lunarnovaa Lunarnovaa merged commit 02c285c into snugnug:main Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants