Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module for foot and keepassxc #8

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Add module for foot and keepassxc #8

merged 2 commits into from
Feb 11, 2025

Conversation

nydragon
Copy link
Contributor

@nydragon nydragon commented Feb 7, 2025

This PR adds 2 modules for configuring foot and keepassxc.

It also includes a way to set the configuration location.

@Lunarnovaa
Copy link
Collaborator

Is there a particular reason for adding an option for the file destination?

Lunarnovaa
Lunarnovaa requested changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@Lunarnovaa Lunarnovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, but be sure to remove the destination options. Otherwise, just code style preferences that you can ignore if you want.

Be sure to nix fmt after changes.

@nydragon
Copy link
Contributor Author

Thank you for the review!

@Lunarnovaa
Copy link
Collaborator

Please in the future don't change commit history. In this case, you should've added commits to satisfy my requested changes.

@Lunarnovaa Lunarnovaa merged commit 0537c6a into snugnug:main Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lunarnovaa Lunarnovaa Lunarnovaa requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nydragon @Lunarnovaa