Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coffee #26

Merged
merged 7 commits into from
May 19, 2019
Merged

Add coffee #26

merged 7 commits into from
May 19, 2019

Conversation

snurby7
Copy link
Owner

@snurby7 snurby7 commented May 19, 2019

Change Notes

  • A generic form has been added for adding a Coffee
  • Server has been updated to add a coffee correctly
  • Additional interfaces for later usages.
  • Reach Router has been brought into the fold
  • README.md has been updated to show the new connection string format (mine was wrong)

@snurby7 snurby7 requested a review from jcuadrosj May 19, 2019 18:11
@todo
Copy link

todo bot commented May 19, 2019

Ideally this will be a login page if #20 is ever done */}

{/* TODO: Ideally this will be a login page if https://github.com/snurby7/coffee-rates/issues/20 is ever done */}
<AddCoffeePage path='/' />
<LoginPage path='/login' />
</Router>
);
}


This comment was generated by todo based on a TODO comment in 711c938 in #26. cc @snurby7.

@todo
Copy link

todo bot commented May 19, 2019

Replace Select options with CoffeeStars

Updat the below select to use the coffee star component built in #25


@todo Replace Select options with CoffeeStars
@body Updat the below select to use the coffee star component built in #25
*/}
<select
value={coffee.rating}
onChange={event => setCoffee({ ...coffee, rating: parseInt(event.target.value, 10) })}


This comment was generated by todo based on a @todo comment in 711c938 in #26. cc @snurby7.

@todo
Copy link

todo bot commented May 19, 2019

#25

// TODO https://github.com/snurby7/coffee-rates/issues/25
return <div>Nothing here yet, it needs the magic still.</div>;
};
export default CoffeeStars;


This comment was generated by todo based on a TODO comment in 711c938 in #26. cc @snurby7.

@todo
Copy link

todo bot commented May 19, 2019

Make the Server response more robust

This file really needs some work so #5 can have an easier time knowing what's what.


@todo Make the Server response more robust
@body This file really needs some work so #5 can have an easier time knowing what's what.
*/
/**
* @description A generic container for the API to send back so all commands are structured the same


This comment was generated by todo based on a @todo comment in 711c938 in #26. cc @snurby7.

@todo
Copy link

todo bot commented May 19, 2019

this could eventually have the userID passed so it's found by the user

// TODO: this could eventually have the userID passed so it's found by the user
}
const AddCoffeePage: React.FC<IAddCoffeePageProps> = () => {
// TODO: Ideally this will be a userId if https://github.com/snurby7/coffee-rates/issues/20 is ever done
const mockUserId = 'mock-user-id';


This comment was generated by todo based on a TODO comment in 711c938 in #26. cc @snurby7.

@todo
Copy link

todo bot commented May 19, 2019

Ideally this will be a userId if #20 is ever done

// TODO: Ideally this will be a userId if https://github.com/snurby7/coffee-rates/issues/20 is ever done
const mockUserId = 'mock-user-id';
return (
<main>
<AddCoffeeForm userId={mockUserId} />
</main>


This comment was generated by todo based on a TODO comment in 711c938 in #26. cc @snurby7.

@todo
Copy link

todo bot commented May 19, 2019

Create a Modal Service

Whenever a save or anything is successful or an error needs to be shown it should come through here


@todo Create a Modal Service
@body Whenever a save or anything is successful or an error needs to be shown it should
come through to this Utility for handling
*/
/**
* @description Wrapper around the window.alert method, will eventually be a modal


This comment was generated by todo based on a @todo comment in 711c938 in #26. cc @snurby7.

Copy link
Collaborator

@jcuadrosj jcuadrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client/src/util/ApiUtility.ts Outdated Show resolved Hide resolved
backend/contracts/ICoffeeProfile.ts Show resolved Hide resolved
backend/contracts/index.ts Show resolved Hide resolved
@todo
Copy link

todo bot commented May 19, 2019

this could eventually have the userID passed so it's found by the user

// TODO: this could eventually have the userID passed so it's found by the user
}
const AddCoffeePage: React.FC<IAddCoffeePageProps> = () => {
// TODO: Ideally this will be a userId if https://github.com/snurby7/coffee-rates/issues/20 is ever done
const mockUserId = 'mock-user-id';


This comment was generated by todo based on a TODO comment in 15b6680 in #26. cc @snurby7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants