Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix unsafe object get #11

Merged
merged 1 commit into from
Jun 4, 2020
Merged

fix: fix unsafe object get #11

merged 1 commit into from
Jun 4, 2020

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Jun 4, 2020

  • Tests written and linted ℹ︎
  • Documentation written ℹ︎
  • Commit history is tidy ℹ︎

What this does

When the err did not have a response the whole thing threw with an Unclassified error. With the safe get the generic default errors bubble up.

@aarlaud aarlaud merged commit e36acce into develop Jun 4, 2020
@aarlaud aarlaud deleted the fix/unexpected-error branch June 4, 2020 21:42
@aarlaud
Copy link
Contributor

aarlaud commented Jun 4, 2020

🎉 This PR is included in version 1.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lili2311 @aarlaud