Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated set-output with GITHUB_OUTPUT #110

Merged

Conversation

pergardebrink
Copy link
Contributor

When running the GitHub Action for snyk-setup-action: https://github.com/snyk/actions/tree/master/setup#snyk-setup-action, I get an error that the set-output is deprecated in GitHub Actions:
image

This PR changes set-output to use the GITHUB_OUTPUT instead as recommended by GitHub: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

@pergardebrink pergardebrink requested a review from a team as a code owner October 31, 2022 10:53
@pergardebrink
Copy link
Contributor Author

Another related issue: The snyk version result for the github action is different from what you normally see when running the Snyk CLI locally.

For example, running the GitHub action vs. my local machine:
GitHub Actions output for snyk version:

1.1045.0 (standalone)

Locally (windows)

$ snyk version
1.1045.0

It seems like the linux build has a (standalone) suffix. If I download the snyk cli the same way as the GitHub Action does by pulling like this: https://docs.snyk.io/snyk-cli/install-the-snyk-cli#install-with-standalone-executables I only get the (standalone) suffix when running the linux standalone binary and not with the windows binary.

@codebydant
Copy link

codebydant commented Feb 8, 2023

@mathroule would be nice to have the issues or discussions tabs enabled to ask questions or feature requests. It would be nice to have support for defining PR title and commit message format with a prefix in order to meet PR title validator in the CI pipelines.

Currently the format is [snyk] bump ...

@bastiandoetsch
Copy link
Contributor

LGTM, thanks for the contribution.

@bastiandoetsch bastiandoetsch merged commit 8061827 into snyk:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants