feat: scan gradle projects behind --all-projects #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lili2311
force-pushed
the
feat/enable-gradle-all-projects
branch
18 times, most recently
from
ab9c63e to
aa6f1d6
Compare
lili2311
commented
Aug 6, 2020
src/cli/commands/monitor/index.ts
Outdated
| maybePrintDepGraph(options, projectDeps.depGraph); | ||
| projectName = projectDeps.depGraph.rootPkg.name; | ||
| projectName = | ||
| projectDeps.meta.gradleProjectName || |
There was a problem hiding this comment.
display the correct gradle project name if present
lili2311
commented
Aug 6, 2020
| @@ -547,34 +547,6 @@ export const AllProjectsTests: AcceptanceTests = { | |||
| ); | |||
| }, | |||
|
|
|||
| '`test large-mono-repo with --all-projects and --detection-depth=2`': ( | |||
There was a problem hiding this comment.
the test below covers this one too, seems unnessesary
lili2311
force-pushed
the
feat/enable-gradle-all-projects
branch
4 times, most recently
from
457f8f4 to
ffea250
Compare
lili2311
commented
Aug 6, 2020
| @@ -129,23 +129,28 @@ function filterForDefaultManifests(files: string[]) { | |||
| ...pathLib.parse(p), | |||
| packageManager: detectProjectTypeFromFile(p), | |||
| })) | |||
| .sortBy('dir') | |||
There was a problem hiding this comment.
important so we find the folders higher up first
lili2311
force-pushed
the
feat/enable-gradle-all-projects
branch
from
ffea250 to
3b227a2
Compare
ghost
requested review from
lili2311
force-pushed
the
feat/enable-gradle-all-projects
branch
from
3b227a2 to
7c2a2af
Compare
lili2311
force-pushed
the
feat/enable-gradle-all-projects
branch
from
7c2a2af to
a2bfc89
Compare
|
🎉 This PR is included in version 1.372.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
[x] Add monitor test
[x] Update the
test --all-projectsto assertallSubProjectsis passedWhat does this PR do?
build.gradlefiles behind--all-projectsflag with an implied--all-sub-projectsto scan everything at once.find()function to only detect root levelbuild.gradlefiles for projects and not scan any nested files unnecessarilyWhere should the reviewer start?
https://github.com/snyk/snyk/compare/feat/enable-gradle-all-projects?expand=1#diff-46067fcff3540c568100c842d5c0f6a4R190
How should this be manually tested?
snyk test --all-projectsin thetest/acceptance/workspacesshould now also return gradle results.Screenshots