fix(build): use node 14 for alpine executable #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackuB
force-pushed
the
feat/smoke-test
branch
9 times, most recently
from
4d4a811 to
abf13a4
Compare
JackuB
force-pushed
the
feat/smoke-test
branch
from
abf13a4 to
132afe2
Compare
ghost
requested review from
pavel-snyk
approved these changes
Aug 17, 2020
|
🎉 This PR is included in version 1.377.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced May 14, 2022
This was referenced May 14, 2022
This was referenced May 14, 2022
This was referenced Sep 23, 2022
This was referenced Sep 24, 2022
This was referenced Sep 25, 2022
This was referenced Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our CLI Alpine executable based on Node v12 is throwing segfault errors.
This PR introduces an Alpine docker container that runs shellspec tests for our CLI.
Smoke tests are passing with the latest working version using Node v14. They will fail in this PR, until we release a new version with v14:
