Refactor and improve testing and un-skip skipped test re JSON file output #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxjeffos
force-pushed
the
test/unskip-and-fix-flakey-test
branch
from
0506999 to
512cd50
Compare
maxjeffos
force-pushed
the
test/unskip-and-fix-flakey-test
branch
from
512cd50 to
20d560b
Compare
JackuB
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor to extract a function for better testability so we can better and more directly test that we can output JSON to a given absolute path and create directories as required without having to run the entire snyk test from the outside in order to do so.
Any background context you want to provide?
Tests in test/jest/acceptance/cli-json-file-output.spec.ts can be flakey and one of them in particular,
test --json-file-output can handle an absolute pathwas recently skipped to unblock other work.What are the relevant tickets?
Where the test was skipped: 453db4c