Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use break cycles logic of depgraph for snyk-gradle #1775

Merged
merged 1 commit into from
Mar 29, 2021

Commits on Mar 29, 2021

  1. feat: use break cycles logic of depgraph

      - Deleted findCycles and breakCycles logic from snyk-gradle-plugin
      - Multi-config fixture plugin.test.ts has top level deps amount number
        aligned and with correct count, we were appending transitive deps as
    top to avoid loosing them due of lack of cycle/break support in
    dep-graph lib.
    
      - Dependency **org.jetbrains.kotlin:kotlin-stdlib** is no longer available as
      direct dep in **kotlin.test.ts** (it was wrong) as it's a transitive  dependency see screenshot below.
      It was being `appended` as top due of the lack of cycle/break support in dep-graph lib
    
    <img width="542" alt="dependencies" src="https://user-images.githubusercontent.com/40601533/112800442-52873500-9078-11eb-98f9-3b305211e879.png">
    
      - Added @snyk/dep-graph changes
    
        v1.27.1 remove cache in pathsToRoot
    
        v1.27 break cyclic graphs when converting into tree
    
        v1.26 support cycles in pkgPathsToRoot and countPathsToRoot
    anthogez committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    a62594b View commit details
    Browse the repository at this point in the history