Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saving snyk as a devdependency #18

Closed
wants to merge 1 commit into from

Conversation

antialias
Copy link

wizard saves snyk in devDependencies instead of dependencies

@antialias antialias force-pushed the save-dev-snyk branch 2 times, most recently from b685055 to ee9d7de Compare March 11, 2016 15:59
@johannakoll
Copy link
Contributor

Thanks for the PR @antialias! @remy will take a look once he is back at the office on Wednesday next week.

@remy
Copy link
Contributor

remy commented Mar 11, 2016

Snyk actually needs to go into dependencies (not dev) if it's being used to apply a protect.

Say for example you're using the request package that live patches a vuln in hawk. If request puts snyk in the devDeps, then when request is installed as your production dep, request's own devDeps won't be installed, and thus the patch won't be applied to hawk (as intended by the authors of the request package).

It's intentionally that snyk isn't searched for in the devDeps because of this particular logic.

I hope that makes sense.

@remy remy closed this Mar 11, 2016
@antialias
Copy link
Author

Thanks for the explanation. That makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants