Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust spacing on 'test' output #197

Merged
merged 1 commit into from
Aug 20, 2018
Merged

fix: adjust spacing on 'test' output #197

merged 1 commit into from
Aug 20, 2018

Conversation

adrukh
Copy link
Contributor

@adrukh adrukh commented Aug 19, 2018

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

A cosmetics issue, aligning spaces in output like this:

Testing /Users/anton/code/snyk/snyk...

Organisation:      snyk
Package manager:   npm
Target file:       package.json
Open source:       no
Project path:      /Users/anton/code/snyk/snyk
Local Snyk policy: found
Licenses:          enabled

✓ Tested 246 dependencies for known issues, no vulnerable paths found.

@adrukh adrukh self-assigned this Aug 20, 2018
Copy link
Contributor

@miiila miiila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return s;
}

var padding = Array.from({length: padLength + 1}).join(' ');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it would work on Node 4. Alternatively, here's another thing that probably wouldn't work: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darscan You are right - not even on Node 6, based on https://node.green/.

@adrukh Sorry, repeat should be fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grrr was too fast with the merge button!

Will amend this

@adrukh adrukh merged commit dbd1fa2 into master Aug 20, 2018
@adrukh adrukh deleted the fix/spacing branch August 20, 2018 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants