chore: unused exports linter and fixing #2130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodora-sandu
force-pushed
the
chore/remove-unused-files
branch
from
37bd45f to
320fc5d
Compare
teodora-sandu
force-pushed
the
chore/remove-unused-files
branch
3 times, most recently
from
c3f6c74 to
e3cbb18
Compare
teodora-sandu
commented
Aug 2, 2021
| @@ -1,6 +1,7 @@ | |||
| const Configstore = require('configstore'); | |||
| const pkg = require(__dirname + '/../../package.json'); | |||
|
|
|||
| // eslint-disable-next-line import/no-unused-modules | |||
There was a problem hiding this comment.
Running into the following bug which was fixed in typescript@4.x if we don't export it: microsoft/TypeScript#40718
teodora-sandu
commented
Aug 2, 2021
| @@ -45,6 +45,7 @@ export class TestLimitReachedError extends CustomError { | |||
|
|
|||
| // Sub-interface of FormattedResult that we really only use to make test | |||
| // fixtures easier to create. | |||
| // eslint-disable-next-line import/no-unused-modules | |||
There was a problem hiding this comment.
Running into the following bug which was fixed in typescript@4.x if we don't export it: microsoft/TypeScript#40718
teodora-sandu
commented
Aug 2, 2021
| @@ -31,6 +31,7 @@ const simpleGradleGraph = depGraphLib.createFromJSON({ | |||
| }, | |||
| }); | |||
|
|
|||
| // eslint-disable-next-line import/no-unused-modules | |||
There was a problem hiding this comment.
Flaky test is temporarily disabled/commented out, so disabling the rule for this export.
teodora-sandu
force-pushed
the
chore/remove-unused-files
branch
from
e3cbb18 to
6d20461
Compare
teodora-sandu
force-pushed
the
chore/remove-unused-files
branch
from
6d20461 to
9918857
Compare
|
Closing due to age. Feel free to re-open if it's still active. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a linter for unused exports, which ensures that once we stop using an export we'll be notified.
Where should the reviewer start?