fix: better error when org is not found for snyk code #2295
+19
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saark-snyk
force-pushed
the
fix/code-org-not-found
branch
from
214659d to
5da4c73
Compare
saark-snyk
changed the title
|
Arvi3d
reviewed
Oct 4, 2021
| @@ -17,7 +17,7 @@ import { jsonStringifyLargeObject } from '../../../../src/lib/json'; | |||
| import { ArgsOptions } from '../../../../src/cli/args'; | |||
|
|
|||
| const { getCodeAnalysisAndParseResults } = analysis; | |||
| const osName = require('os-name'); | |||
| import osName = require('os-name'); | |||
There was a problem hiding this comment.
required: this looks like a typo. import and require
There was a problem hiding this comment.
This is not a typo, it's a way of importing es modules that use export =
neonnoon
approved these changes
Oct 4, 2021
src/lib/plugins/sast/validate.ts
Outdated
| @@ -16,7 +18,6 @@ export async function validateCodeTest(options: Options) { | |||
| } | |||
|
|
|||
| // TODO: We would need to remove this once we fix circular import issue | |||
There was a problem hiding this comment.
Suggestion: kill this line as well?
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR shows better error when org is not found for user (instead of showing "Snyk code is not enabled for org")
Where should the reviewer start?
How should this be manually tested?
run
snyk code test --org=foowith this PRAny background context you want to provide?
What are the relevant tickets?
https://snyksec.atlassian.net/browse/COD-556?atlOrigin=eyJpIjoiMTBlZjliODkxMjM4NGVkNjgzMGEyZmE5M2NkMDExMWMiLCJwIjoiaiJ9
Screenshots
Additional questions