Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add gcr acceptance test [CFG-1111] #2381

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

teodora-sandu
Copy link
Contributor

What does this PR do?

This PR adds acceptance tests for GCR, to prove that we support it and make sure we keep supporting it. The credentials are for a GCR service account set up for automated testing.

@teodora-sandu teodora-sandu requested a review from a team as a code owner November 23, 2021 10:20
@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2021

Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against 7c99334

Copy link
Contributor

@ofekatr ofekatr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One env variable has a typo, but other than that looks great 🚀

test/jest/acceptance/iac/custom-rules.spec.ts Outdated Show resolved Hide resolved
@teodora-sandu teodora-sandu force-pushed the chore/add-gcr-acceptance-test branch from 25fc6dd to 7c99334 Compare November 23, 2021 18:27
Copy link
Contributor

@ofekatr ofekatr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants