-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: critical level is considered error in sarif #2492
Conversation
|
6c0a2d8
to
2e762ec
Compare
2e762ec
to
2900e3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🎉
530dbb7
to
093c166
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work here @teodora-sandu 🎉
Could you please copy your GitHub's note into your commit's message body? Thanks!
Makes sure that critical security issues are treated as errors in SARIF for code scanning alerts. At the moment they would be treated as warnings, which is not correct as critical is the highest severity.
093c166
to
a034e57
Compare
What does this PR do?
This PR makes sure that
critical
security issues are treated as errors in SARIF for code scanning alerts. At the moment they would be treated as warnings, which is not correct ascritical
is the highest severity.How should this be manually tested?
Snyk IaC only supports critical severity via custom rules.
npm run build
insnyk/snyk
snyk-dev iac test ./rules/CUSTOM-RULE-1/fixtures/denied.tf --rules=bundle.tar.gz
insnyk/custom-rules-example
to see Critical issueCUSTOM-RULE-1
snyk-dev iac test ./rules/CUSTOM-RULE-1/fixtures/denied.tf --rules=bundle.tar.gz --sarif
insnyk/custom-rules-example
to see that it's anerror
Any background context you want to provide?
This is a byproduct of Snyk IaC investigating our existing SARIF output in https://snyksec.atlassian.net/browse/CFG-1278 and reading the documentation at https://docs.github.com/en/code-security/code-scanning/integrating-with-code-scanning/sarif-support-for-code-scanning#supported-sarif-output-file-properties to find out if anything is missing.
Screenshots