feat: support unmanaged snyk security url #2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthogez
force-pushed
the
feat/unmanaged-security-url
branch
from
7dc957d to
74a9d26
Compare
danlucian
force-pushed
the
feat/unmanaged-security-url
branch
5 times, most recently
from
2df80c0 to
b7eec17
Compare
anthogez
commented
Jan 12, 2022
| expect(isUnmanagedEcosystem('docker')).toBeFalsy(); | ||
| expect(isUnmanagedEcosystem('code')).toBeFalsy(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
@danlucian good work here! What if we go with?
describe('isUnmanagedEcosystem fn', () => {
it.each`
actual | expected
${'cpp'} | ${true}
${'docker'} | ${false}
${'code'} | ${false}
`(
'should validate that given $actual as input, is considered or not an unmanaged ecosystem',
({ actual, expected }) => {
expect(isUnmanagedEcosystem(actual)).toEqual(expected);
},
);
});
There was a problem hiding this comment.
Looks good, I applied the changes 💪
danlucian
force-pushed
the
feat/unmanaged-security-url
branch
3 times, most recently
from
9f0874d to
31b755c
Compare
danlucian
approved these changes
Jan 12, 2022
|
@danlucian let's wait this one to be merged snyk/snyk-cpp-plugin#61 |
anthogez
force-pushed
the
feat/unmanaged-security-url
branch
from
31b755c to
dda59c1
Compare
Co-authored-by: @danlucian lucian.rosu@snyk.io Allows users with snykUnmanagedVulnDB ff in org level to visualize https://security.snyk.io/vuln/SNYK-UNMANAGED-CURL-2317584 rather than nvd url Depends on snyk/snyk-cpp-plugin#61 with feature flag <img width="470" alt="Screen Shot 2022-01-11 at 11 53 47" src="https://user-images.githubusercontent.com/40601533/148922100-369c9d87-73c2-4dcc-881c-4dffac170758.png"> without feature flag <img width="809" alt="Screen Shot 2022-01-11 at 11 53 03" src="https://user-images.githubusercontent.com/40601533/148922121-d03f6ac3-165c-4539-b8bc-f7ef5ce93ecb.png">
anthogez
force-pushed
the
feat/unmanaged-security-url
branch
from
dda59c1 to
a3ec49d
Compare
ghost
suggested changes
Jan 12, 2022
There was a problem hiding this comment.
By adding branches for "unmanaged", are we not leaking abstractions? Why isn't unmanaged-specific logic being solved with the plugin itself? Is the plugin API too limited? Should it be improved?
I kind of recall a similar conversation before, but don't remember if a decision was made.
Happy to approve since there are similar existing branches already. Left a comment for some types that need changing.
ghost
approved these changes
Jan 12, 2022
This was referenced Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: @danlucian lucian.rosu@snyk.io
Allows users with snykUnmanagedVulnDB ff in org level to visualize
https://security.snyk.io/vuln/SNYK-UNMANAGED-CURL-2317584 rather than
nvd url
Depends on snyk/snyk-cpp-plugin#61
with feature flag
without feature flag
