Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump snyk docker plugin version golang fixes #3446

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

yaronschwimmer
Copy link

What does this PR do?

We had issues with Go modules not being detected. Version 5.0.1 of
snyk-docker-plugin should fix those issues.
This commit includes a workaround since we have a blocked PR (#3433) for
making app vulns the default using the lates version of
snyk-docker-plugin. Until we are able to make scanning app vulns the
default, we need to make sure that we set exclude-app-vulns option
when a user doesn't set the app-vulns option.

What are the relevant tickets?

https://snyksec.atlassian.net/browse/MYC-131

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2022

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • src/cli/commands/monitor/index.ts
  • src/cli/commands/test/index.ts
  • test/tap/cli-monitor.acceptance.test.ts
  • test/tap/cli-test/cli-test.docker.spec.ts

Generated by 🚫 dangerJS against 8d55bcd

@yaronschwimmer yaronschwimmer force-pushed the fix/bump-docker-plugin-go-modules branch 3 times, most recently from f022600 to 39ed48a Compare July 10, 2022 13:52
We had issues with Go modules not being detected. Version 5.0.1 of
`snyk-docker-plugin` should fix those issues.
This commit includes a workaround since we have a blocked PR (#3433) for
making app vulns the default using the lates version of
`snyk-docker-plugin`. Until we are able to make scanning app vulns the
default, we need to make sure that we set `exclude-app-vulns` option
when a user doesn't set the `app-vulns` option.
@yaronschwimmer yaronschwimmer force-pushed the fix/bump-docker-plugin-go-modules branch from 39ed48a to 8d55bcd Compare July 10, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants