fix: use FormattedPath [TFCSCM-124]

[teodora-sandu]

• Follows CONTRIBUTING rules

What does this PR do?

This removes the formattedPath function and instead uses the FormattedPath field returned by snyk-iac-test. It also updates the version of snyk-iac-test to https://github.com/snyk/snyk-iac-test/releases/tag/v0.14.0.

Any background context you want to provide?

It contains loads of good fixes.

What are the relevant tickets?

• Jira ticket TFCSCM-124

Screenshots

[teodora-sandu]

Need to figure out how to generate https://github.com/snyk/snyk/blob/6f4b755b5d78b095a04a9c3fb0d57994ac6af8df/test/jest/unit/iac/process-results/fixtures/snyk-iac-test-results.json. @YairZ101 Do you have any instructions for this?

[YairZ101]

Do you have any instructions for this?

No, when I generated this fixture I simply took several files from our goof repo, moved them to a new dir, and scanned the dir.
Do you think we should have a documented procedure to generate this fixture?

[teodora-sandu]

@YairZ101 I think documenting it would be good, even if it's just a comment at the top of this file. I assume you ran snyk-iac-test directly on the files to generate that output?

[YairZ101]

@YairZ101 I think documenting it would be good, even if it's just a comment at the top of this file. I assume you ran snyk-iac-test directly on the files to generate that output?

I personally used the TS CLI using debug mode but you can also use snyk-iac-test if you prefer.

[ipapast]

hey @teodora-sandu , I found the files that Yair used from a different repo.

1. On the first commit fd5227f I put them into their own fixtures folder, so we can have specific ones to test.

The json tests will not pass of course only with this commit.

2. Then, I tried to generate the expected results from this file (and trim unnessary things as the fixtures have changed quite a bit) - 8ddd8f3

3. I am now going to merge the conflicts and get the latest version for snyk-iac-test as it has bug fixes and it also involves the "float" bug you just fixed today - it's in these fixtures.
   Edit: merged conflicts and now using v0.13.1 like master, which includes bug fixes.

4. Updated the msg field in the experimental output on this commit: a3169a9

Now the tests should pass. (they do 🎉 )

However, have a look again the msg - it looks a bit strange to me that it includes the resource. in front, but I am not up to date with the current formatting. I confirm that this is how it looks in the experimental output though. We could chat about it tomorrow if you like.