Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CTX-190] feat: share cache path with IaC plugin #3554

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

craigfurman
Copy link

@craigfurman craigfurman commented Aug 5, 2022

What does this PR do?

Pass the IaC cache path to snyk-iac-test so that all subcomponents can
share cached resources.

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

Companion to https://github.com/snyk/snyk-iac-test/pull/64. Do not merge until that is released.

What are the relevant tickets?

https://snyksec.atlassian.net/browse/CTX-190

Screenshots

Additional questions

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

Warnings
⚠️

You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against e254c0c

@craigfurman craigfurman force-pushed the feat/share-cache-path-iac branch from c2201a5 to 96a44f9 Compare August 8, 2022 10:13
@craigfurman craigfurman marked this pull request as ready for review August 11, 2022 08:11
@craigfurman craigfurman requested a review from a team as a code owner August 11, 2022 08:11
Pass the IaC cache path to snyk-iac-test so that all subcomponents can
share cached resources.
@craigfurman craigfurman force-pushed the feat/share-cache-path-iac branch from 96a44f9 to e254c0c Compare August 11, 2022 09:11
@craigfurman craigfurman merged commit d188644 into master Aug 11, 2022
@craigfurman craigfurman deleted the feat/share-cache-path-iac branch August 11, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants