New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add unmanaged service test call ff #3603

Merged

dagrest merged 1 commit into master from feat/add-unmanaged-service-test-call-ff

Sep 20, 2022

dagrest commented Aug 18, 2022

Follows CONTRIBUTING rules

What does this PR do?

Implements Feature Flag to switch to a new polling function that uses a new Unmanaged Service APIs
Implements a new polling function that uses a new Unmanaged Service APIs

Where should the reviewer start?

Implementation begins in the following function: resolveAndTestFacts

How should this be manually tested?

Use the following options: test --unmanaged, do not forget to enable feature flag, current name is 'snykNewUnmanagedTest'

What are the relevant tickets?

dagrest requested review from a team as code owners

August 18, 2022 07:10

dagrest requested review from dpp, admons and julianpellasrice-snyk

August 18, 2022 07:10

dagrest assigned dekelund and danielroymoore

dekelund reviewed

View reviewed changes

src/lib/ecosystems/resolve-test-facts.ts Outdated Show resolved Hide resolved

dekelund reviewed

View reviewed changes

src/lib/ecosystems/resolve-test-facts.ts Outdated Show resolved Hide resolved

dekelund reviewed

View reviewed changes

src/lib/ecosystems/resolve-test-facts.ts Outdated Show resolved Hide resolved

dekelund reviewed

View reviewed changes

src/lib/ecosystems/resolve-test-facts.ts Outdated Show resolved Hide resolved

dekelund reviewed

View reviewed changes

src/lib/ecosystems/types.ts Outdated Show resolved Hide resolved

dekelund reviewed

View reviewed changes

test/jest/unit/lib/ecosystems/fixtures/create-dep-graph-response.ts Outdated Show resolved Hide resolved

dekelund reviewed

View reviewed changes

test/jest/unit/lib/ecosystems/fixtures/create-dep-graph-response.ts Show resolved Hide resolved

dekelund reviewed

View reviewed changes

test/jest/unit/lib/ecosystems/fixtures/get-dep-graph-response.ts Outdated Show resolved Hide resolved

dekelund reviewed

View reviewed changes

src/lib/ecosystems/resolve-test-facts.ts Outdated Show resolved Hide resolved

dekelund reviewed

View reviewed changes

src/lib/ecosystems/resolve-test-facts.ts Outdated Show resolved Hide resolved

danielroymoore force-pushed the feat/add-unmanaged-service-test-call-ff branch from 695a7f7 to 87b7ab3 Compare

September 13, 2022 15:05

dekelund reviewed

View reviewed changes

test/jest/unit/lib/ecosystems/fixtures/issues-response.ts Outdated Show resolved Hide resolved

dekelund reviewed

View reviewed changes

src/lib/ecosystems/resolve-test-facts.ts Show resolved Hide resolved

dekelund reviewed

View reviewed changes

src/lib/ecosystems/unmanaged/types.ts Show resolved Hide resolved

dekelund reviewed

View reviewed changes

src/lib/polling/polling-test.ts

    
                    }

                  }

                }

                return JSON.parse(result.toString());

dekelund Sep 14, 2022

can't we move this return into the try, and reduce number or variables, alternative use a const in the try-block.

dekelund reviewed

View reviewed changes

src/lib/polling/polling-test.ts Outdated Show resolved Hide resolved

dekelund reviewed

View reviewed changes

src/lib/polling/polling-test.ts Outdated Show resolved Hide resolved

dekelund reviewed

View reviewed changes

src/lib/polling/polling-test.ts Show resolved Hide resolved

danielroymoore force-pushed the feat/add-unmanaged-service-test-call-ff branch from 87b7ab3 to d065704 Compare

September 16, 2022 13:25

dekelund approved these changes

View reviewed changes

danielroymoore force-pushed the feat/add-unmanaged-service-test-call-ff branch from d065704 to 1201f7c Compare

September 16, 2022 14:46


          feat: add unmanaged service test call ff

55b6fbb

danielroymoore force-pushed the feat/add-unmanaged-service-test-call-ff branch from 1201f7c to 55b6fbb Compare

September 16, 2022 14:51

Avishagp approved these changes

View reviewed changes

dagrest merged commit a3f87ba into master

dagrest deleted the feat/add-unmanaged-service-test-call-ff branch

September 20, 2022 08:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

danielroymoore danielroymoore left review comments

Avishagp Avishagp approved these changes

dekelund dekelund approved these changes

dpp Awaiting requested review from dpp dpp was automatically assigned from snyk/snyk-open-source

admons Awaiting requested review from admons admons was automatically assigned from snyk/snyk-open-source

julianpellasrice-snyk Awaiting requested review from julianpellasrice-snyk julianpellasrice-snyk was automatically assigned from snyk/snyk-open-source

Labels

None yet