chore: install git on alpine and re-enable test #3825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com>
ofekatr
reviewed
Sep 6, 2022
| @@ -383,7 +383,7 @@ jobs: | |||
| - run: | |||
| name: Installing Node.js + other test dependencies | |||
| command: | | |||
| apk add --update nodejs npm bash maven | |||
| apk add --update nodejs npm bash maven git | |||
There was a problem hiding this comment.
Question: What's the difference between the Alpine image used for testing and a standard Alpine image?
Would Alpine images usually include git out of the box?
There was a problem hiding this comment.
For testing we use a standard Alpine image. Alpine is a hardened linux distribution which comes with almost nothing and not even glibc.
Avishagp
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Install git on the alpine test container and re-enable the previously skipped test.